Update the governance review template to match the new checklists #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecklist. Update issue template accordingly. Signed-off-by: Josh Berkus <[email protected]>
TheFoxAtWork
approved these changes
Dec 18, 2024
bashlion
approved these changes
Jan 3, 2025
Signed-off-by: Josh Berkus <[email protected]>
TheFoxAtWork
approved these changes
Jan 14, 2025
| @@ -23,171 +11,213 @@ Exemplary: project has an extraordinary level of governance development and impl | |||
| Satisfactory: project has appropriate governance for its maturity level and is following that governance | |||
| Mostly Satisfactory: project has mostly appropriate governance, but needs to fix one or two things | |||
| Needs Work: project's governance is lacking and inadequate for its current level of maturity, and needs substantial work to overcome that | |||
|
|
|||
| NOTE: Fill this part as a summary of your review. It is recommended to start from the "Review" section below in the template. | |||
| In Crisis: project appears to have several outstanding, critical issues that require attention, clarity, and/or direct guidance from CNCF in order to return to a state of good health and standing. | |||
There was a problem hiding this comment.
This states "CNCF". Do we need to list the various entities that would need to provide direction? Should this be explicit as to who?
There was a problem hiding this comment.
I don't think so; this is the template for reviewers, not the public document for projects.
geekygirldawn
approved these changes
Jan 14, 2025
|
|
||
| ### Maintainer List(s) | ||
| The project maintains a [listing of subprojects](LINK). This listing appears to be [Very Complete|Mostly Complete|Incomplete]. |
There was a problem hiding this comment.
Suggested change
| The project maintains a [listing of subprojects](LINK). This listing appears to be [Very Complete|Mostly Complete|Incomplete]. | |
| The project maintains a [listing of subprojects - add link]. This listing appears to be [Very Complete|Mostly Complete|Incomplete]. |
Just a nit. With the way it was formatted it looked like it was already a link, not something that needs to be added.
There was a problem hiding this comment.
I followed the way we handle links to be filled in for Project Templates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first part of this cleanup. It updates our governance review template to match the items on the Incubating/Graduating checklist. This lets us review the material supplied by the project directly.
The next part will be finishing the self-assessment guide to match.